Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test for retrieving exit code #852

Merged
merged 1 commit into from Apr 7, 2023
Merged

test for retrieving exit code #852

merged 1 commit into from Apr 7, 2023

Conversation

zhy76
Copy link
Contributor

@zhy76 zhy76 commented Mar 29, 2023

test for retrieving exit code
Fixes: #634

@zhy76 zhy76 requested a review from a team as a code owner March 29, 2023 08:29
@zhy76 zhy76 requested a review from tpapagian March 29, 2023 08:29
@netlify
Copy link

netlify bot commented Mar 29, 2023

✅ Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit 5ba87f3
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/6423f6f1df52280008564ad7
😎 Deploy Preview https://deploy-preview-852--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@zhy76
Copy link
Contributor Author

zhy76 commented Mar 29, 2023

cc @kkourt PTAL, Thanks!

@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/lint-codeql.yml:analyze. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

tixxdz
tixxdz reviewed Mar 31, 2023
View reviewed changes
Copy link
Member

@tixxdz tixxdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! some comments below ;-)

pkg/sensors/exec/exit_test.go Outdated Show resolved Hide resolved
pkg/sensors/exec/exit_test.go Outdated Show resolved Hide resolved
pkg/sensors/exec/exit_test.go Outdated Show resolved Hide resolved
pkg/sensors/exec/exit_test.go Outdated Show resolved Hide resolved
@zhy76
test for retrieving exit code
4613129 
Signed-off-by: Haiyu Zuo <958474674@qq.com>
@zhy76
Copy link
Contributor Author

zhy76 commented Apr 3, 2023 •
edited

Then later in an other PR in your exit-code you may also try to make it signal to itself and ensure that the field "signal": "SIGINT" example in the process_exit event is set as an example, then you can combine with the exit code too, etc.

I'll add this in an other PR. PTAL, thanks! @tixxdz

@jrfastab
Copy link
Contributor

jrfastab commented Apr 7, 2023

I'm happy with this so will merge it. Please address any follup from reviewers if they come back with feedback.

@jrfastab jrfastab merged commit e27bb6a into cilium:main Apr 7, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tixxdz tixxdz tixxdz left review comments

@tpapagian tpapagian Awaiting requested review from tpapagian tpapagian is a code owner automatically assigned from cilium/tetragon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test for retrieving exit code
3 participants
@zhy76 @jrfastab @tixxdz