TracingPolicy examples: use portable symbols for syscalls #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch includes the change done by this command: find . -type f -name '*' -print0 | xargs -0 sed -i 's/call: "__x64_sys_/call: "sys_/g' Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
Closed
kkourt
approved these changes
Apr 6, 2023
|
A small follow up fix #891 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch includes the change done by this command:
Apart from that, it highlights the issue that for the user, the symbol declared
sys_writewill be different than the symbol he can see from the logs__x64_sys_writeor__arm64_sys_write. Should we do something about it? We could:__x64_sys_writetosys_writeat the agent level so that all logs contain this symbol name;tetra;