Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug-report-template: add an issue template for bug report #898

Merged
merged 1 commit into from Apr 25, 2023
Merged

bug-report-template: add an issue template for bug report #898

merged 1 commit into from Apr 25, 2023

Conversation

YTGhost
Copy link
Contributor

@YTGhost YTGhost commented Apr 7, 2023

Fixes #894

@YTGhost YTGhost requested a review from a team as a code owner April 7, 2023 06:57
@YTGhost YTGhost requested a review from tixxdz April 7, 2023 06:57
@YTGhost
Copy link
Contributor Author

YTGhost commented Apr 7, 2023

@mtardy PTAL

mtardy
mtardy requested changes Apr 7, 2023
View reviewed changes
Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the work, I do appreciate but could you use the GitHub issue YAMLs template as cilium/cilium is using for example.

The file you can inspire from is here https://github.com/cilium/cilium/blob/master/.github/ISSUE_TEMPLATE/bug_report.yaml

.github/ISSUE_TEMPLATE/bug_report_template.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report_template.md Outdated Show resolved Hide resolved
@mtardy mtardy requested review from mtardy and removed request for tixxdz April 7, 2023 08:36
@mtardy mtardy added the kind/enhancement This improves or streamlines existing functionality label Apr 7, 2023
@YTGhost
Copy link
Contributor Author

YTGhost commented Apr 7, 2023

Thanks a lot for the work, I do appreciate but could you use the GitHub issue YAMLs template as cilium/cilium is using for example.

The file you can inspire from is here https://github.com/cilium/cilium/blob/master/.github/ISSUE_TEMPLATE/bug_report.yaml

Ok, thanks for the advice, I'll check it out

@YTGhost YTGhost mentioned this pull request Apr 10, 2023
Closed
@YTGhost
Copy link
Contributor Author

YTGhost commented Apr 15, 2023

@mtardy PTAL

mtardy
mtardy reviewed Apr 17, 2023
View reviewed changes
Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot that's great! :)

.github/ISSUE_TEMPLATE/bug_report_template.yaml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report_template.yaml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report_template.yaml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report_template.yaml Outdated Show resolved Hide resolved
@YTGhost YTGhost force-pushed the add-bug-report-template branch 2 times, most recently from f92ded1 to 58c7612 Compare April 24, 2023 15:35
@YTGhost
Copy link
Contributor Author

YTGhost commented Apr 24, 2023

@mtardy Apologies for not updating promptly due to the busyness of last week. PTAL.

mtardy
mtardy reviewed Apr 24, 2023
View reviewed changes
Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!! Sorry, I missed this one last nit just before!

.github/ISSUE_TEMPLATE/bug_report_template.yaml Outdated Show resolved Hide resolved
@mtardy
Copy link
Member

mtardy commented Apr 24, 2023 •
edited

@mtardy Apologies for not updating promptly due to the busyness of last week. PTAL.

Yeah no worries take your time! This looks great and will be very helpful :)

@YTGhost
Copy link
Contributor Author

YTGhost commented Apr 25, 2023

@mtardy PTAL

@YTGhost
bug-report-template: add an issue template for bug report
9bf2ca6 
Signed-off-by: Liang Deng <283304489@qq.com>
mtardy
mtardy approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sorry for the back and forth!

@mtardy mtardy merged commit a457dcc into cilium:main Apr 25, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtardy mtardy mtardy approved these changes

Assignees
No one assigned
Labels
kind/enhancement This improves or streamlines existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write an issue template for bug report
2 participants
@YTGhost @mtardy