Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: add feature request issue template #972

Merged
merged 1 commit into from May 5, 2023

Conversation

mtardy
Copy link
Member

@mtardy mtardy commented May 4, 2023

I recently saw people using the bug template for feature requests, so here is a template for feature requests.

@mtardy mtardy added the kind/enhancement This improves or streamlines existing functionality label May 4, 2023
@mtardy mtardy requested a review from kkourt May 4, 2023 14:10
@mtardy mtardy requested a review from a team as a code owner May 4, 2023 14:10
@netlify
Copy link

netlify bot commented May 4, 2023

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit 7f6121c
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/6453bce7fb449c0008ed6dc8
😎 Deploy Preview https://deploy-preview-972--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@willfindlay willfindlay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you!

@xmulligan
Copy link
Member

Can we also link this to https://github.com/cilium/design-cfps? It would be great to have a place to keep track of these

@mtardy
Copy link
Member Author

mtardy commented May 4, 2023

Can we also link this to https://github.com/cilium/design-cfps? It would be great to have a place to keep track of these

I explicitly remove that from the description since I was thinking it was cilium/cilium centric, but indeed I can keep this!

Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
@mtardy mtardy force-pushed the pr/mtardy/feature-request-template branch from 7f6121c to cfebe54 Compare May 4, 2023 15:10

For longer proposals, you are welcome to link to an external doc (e.g. a Google doc). We have a [Cilium Feature Proposal template](https://docs.google.com/document/d/1vtE82JExQHw8_-pX2Uhq5acN1BMPxNlS6cMQUezRTWg/edit) that you can use for Tetragon to help you structure your proposal - if you would like to use it, please make a copy and ensure it's publicly visible, and then add the link here.

Once the CFP is close to being finalized, please add it as a PR to the [design-cfps](https://github.com/cilium/design-cfps) repo for final approval.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added here @xmulligan

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

Copy link
Contributor

@kkourt kkourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@xmulligan
Copy link
Member

@mtardy we would like the design repo to cover all projects under the Cilium org

@mtardy mtardy merged commit 58fa558 into main May 5, 2023
17 checks passed
@mtardy mtardy deleted the pr/mtardy/feature-request-template branch May 5, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement This improves or streamlines existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants