Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal_funcs branch ready for testing #124

Open
sonoro1234 opened this issue Mar 25, 2020 · 4 comments
Open

internal_funcs branch ready for testing #124

sonoro1234 opened this issue Mar 25, 2020 · 4 comments

Comments

@sonoro1234
Copy link
Contributor

sonoro1234 commented Mar 25, 2020

https://github.com/cimgui/cimgui/tree/internal_funcs

Still not working with docking branch 1.76WIP

Merged in master

@sonoro1234 sonoro1234 pinned this issue Mar 25, 2020
@sonoro1234 sonoro1234 unpinned this issue Mar 28, 2020
@sonoro1234 sonoro1234 pinned this issue Mar 28, 2020
@ocornut
Copy link

ocornut commented Apr 13, 2020

I'm really confused, this is all output in the SAME cimgui.h instead of cimgui_internal.h ?

This is a recipe for disaster where people would

  1. get confused by the mixture of public facing and internal functions in the same file.
  2. accidentally use functions that will break in future versions.

Any reason for not outputting a separate cimgui_internal.h file?

@sonoro1234
Copy link
Contributor Author

Any reason for not outputting a separate cimgui_internal.h file?

#108 (comment)

Althought I could try to put it in separated files after the parsing

2\. accidentally use functions that will break in future versions.

This is independent from the fact that they are in the same header, as the bindings users dont know from which header they come.

@sonoro1234 sonoro1234 unpinned this issue Apr 18, 2020
@ocornut
Copy link

ocornut commented Feb 3, 2021

I understand this may not be easy to implement but shouldn't we at least have an open issue for it?

I think that along with #139 this is very important to distinguish those into a cimgui_internal.h file.

How can we help?

@ocornut
Copy link

ocornut commented Mar 4, 2021

While looking at cimgui.h today I came with the idea that if cimgui_internal.h is more work to achieve, in the meantime MAYBE it would be possible to move the internal stuff AT THE END of cimgui.h and behind a user accessible ifdef?
I don't know if that's simpler to implement, just an idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants