Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added code for problem 105 #386

Merged
merged 3 commits into from Dec 10, 2020
Merged

Added code for problem 105 #386

merged 3 commits into from Dec 10, 2020

Conversation

aashishat718
Copy link

@Math-O5 Added code for problem 105 of issue #373

@Math-O5
Copy link
Collaborator

Math-O5 commented Dec 10, 2020

@aashishat718 Hi, 105 is alright, but q104 should not be in this pull request.

@aashishat718
Copy link
Author

@Math-O5 Hi, I have removed q104 from this pull request, please review it.

@Math-O5
Copy link
Collaborator

Math-O5 commented Dec 10, 2020

@aashishat718 Well done!

@Math-O5
Copy link
Collaborator

Math-O5 commented Dec 10, 2020

@aashishat718 In the future, please don't use camel case when naming variables. However, this is simc-codes so I think there is no problem. (camelCase is "sumNNaturalNumber", but should be: "sum_n_natural_numbers".

@aashishat718
Copy link
Author

@aashishat718 In the future, please don't use camel case when naming variables. However, this is simc-codes so I think there is no problem. (camelCase is "sumNNaturalNumber", but should be: "sum_n_natural_numbers".

I will take care of this.

@Math-O5 Math-O5 merged commit e9a91e7 into cimplec:master Dec 10, 2020
@aashishat718 aashishat718 deleted the in-373 branch December 10, 2020 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants