Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bollinger Bands standard deviation calculation is different from other implementations #103

Merged
merged 2 commits into from
Jun 24, 2022

Conversation

cinar
Copy link
Owner

@cinar cinar commented Jun 23, 2022

Describe Request

Bollinger Bands standard deviation calculation is different from other implementations

Fixed #102

Change Type

Bug fix.

@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2022

Codecov Report

Merging #103 (acce729) into master (f4fab52) will increase coverage by 0.59%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #103      +/-   ##
==========================================
+ Coverage   56.75%   57.35%   +0.59%     
==========================================
  Files          13       13              
  Lines        1221     1217       -4     
==========================================
+ Hits          693      698       +5     
+ Misses        520      511       -9     
  Partials        8        8              
Impacted Files Coverage Δ
volatility_indicators.go 55.14% <100.00%> (+6.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4fab52...acce729. Read the comment docs.

@cinar cinar merged commit 6b80892 into master Jun 24, 2022
@cinar cinar deleted the cinar/issue102 branch June 24, 2022 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bollinger Bands standard deviation calculation is different from other implementations
2 participants