Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/CON-265 #394

Open
wants to merge 17 commits into
base: develop
Choose a base branch
from
Open

feature/CON-265 #394

wants to merge 17 commits into from

Conversation

robertcli
Copy link

Review for Jeff

@robertcli
Copy link
Author

Latest commit contains SpotlessApply.

@robertcli
Copy link
Author

I reversed the order of the history and undo(changes, key, record) is now undoing results accurately. Also: added <= to while loop.

NORMAL: 1565204100041001 ADD hi AS 5 (INTEGER) IN 1 AT 1565204100041001
NORMAL: 1565204154077001 REMOVE hi AS 5 (INTEGER) IN 1 AT 1565204154077001
NORMAL: 1565204154078000 ADD hi AS bye (STRING) IN 1 AT 1565204154078000
NORMAL: 1565282665359000 ADD hi AS 5 (INTEGER) IN 1 AT 1565282665359000
NORMAL: 1565282665363000 REMOVE hi AS bye (STRING) IN 1 AT 1565282665363000

REVERSE: 1565282665363000 REMOVE hi AS bye (STRING) IN 1 AT 1565282665363000
REVERSE: 1565282665359000 ADD hi AS 5 (INTEGER) IN 1 AT 1565282665359000
REVERSE: 1565204154078000 ADD hi AS bye (STRING) IN 1 AT 1565204154078000
REVERSE: 1565204154077001 REMOVE hi AS 5 (INTEGER) IN 1 AT 1565204154077001
REVERSE: 1565204100041001 ADD hi AS 5 (INTEGER) IN 1 AT 1565204100041001

@jtnelson
Copy link
Member

@robertcli you should write some unit tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants