DNET-564 fixed named parameter when query contains comments with quotes #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| return builder.ToString(); | ||
| { | ||
| if (!_paramsRegex.IsMatch(sql)) |
There was a problem hiding this comment.
You make two regex maches. You can call just Matches mehod and check if collection is not empty.
There was a problem hiding this comment.
Absolutly. A new commit is under the way :)
Thank you
|
I'm closing this because it is not working as I expected! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.firebirdsql.org/browse/DNET-564
fixed named parameter when query contains comments with quotes