make Platform::getAssetPath() / loadAsset() const / thread-safe by removing lazy init #1119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itializing asset directories right after constructing Platform. findAndAddDefaultAssetPath() is made virtual so subclasses can override this work if it is meaningless on their platform.
richardeakin
added a commit
that referenced
this pull request
Sep 24, 2015
make Platform::getAssetPath() / loadAsset() const / thread-safe by removing lazy init
richardeakin
added a commit
to richardeakin/Cinder
that referenced
this pull request
Sep 28, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So now the default assets path is searched and added right after Platform is constructed. Platforms where this is wasteful file access, such as android, can override
findAndAddDefaultAssetPath()to disable this functionality.