audio: fix Param applyRamp() perf issue when context is disabled #2101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardeakin
changed the title
3togo
pushed a commit
to 3togo/Cinder
that referenced
this pull request
Aug 12, 2019
…ext_disabled audio: fix Param applyRamp() perf issue when context is disabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a bug where
audio::Param::EventRefs would accumulate when the context is disabled. They'd be cleared once you re-enable the context, but if you were to leave the audio context disabled for a long period of time, then a huge std::list would build up and the performance would degrade.