A collection of updates and fixes #2294
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull from main Cinder library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements a collection of fixes that I've implemented for my own projects. Hopefully at least some of these are useful and, if not, can be adapted to be merged into the main repository :)
linuxif it is defined. This fixes bugs in WSL environments/MTunder MSVC compilation -- causes problems with other libraries and linking/SUMBYSTEM:WINDOWSunder MSVC compilation -- Otherwise the main cinder app definition won't work as it implementsWinMain(IIRC), not the defaultmainfunction, causing compiler errors in MSVCHopefully at least some of the changes in this are useful!