Clear up concurrent circular buffer's size & capacity interface. #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Refers to issue #723 |
|
I'm good with this - anyone object to this (slightly) breaking change? |
| size_t getCapacity() const { return (size_t)mContainer.capacity(); } | ||
|
|
||
| //! Returns the number of items the buffer is currently holding | ||
| size_t getSize() { |
There was a problem hiding this comment.
I think this should be const, and as such I don't believe it needs the protection of the mutex (see: you don't know const).
There was a problem hiding this comment.
Hah, I realize in the linked issue I suggested implementing getSize() with a mutex, but then now that I'm thinking about it doesn't seem necessary.
|
Sorry, I had a bit of a brain fart last night when discussing this. To me what you have now is correct, after making getSize() const and the mutex mutable. |
andrewfb
added a commit
that referenced
this pull request
May 1, 2015
Clear up concurrent circular buffer's size & capacity interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.