Build system fixes for develop branch #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support appending ABI-specific suffix to libdir as needed for install on multilib systems. This is done via LIB_SUFFIX variable that is used in some other CMake projects.
Fix the stubgen output filename and #include to use the 'abstractstubserver.h' as defined as OUTPUT and listed in README.
Remove duplicate HTTP_SERVER and HTTP_CLIENT conditions inside examples since all examples are conditional to them.
Include examples/CMakeLists.txt independently of COMPILE_EXAMPLES conditional, use it to restrict building programs inside that file. This makes sure that the stub building rules are available for tests even when building examples is disabled. Fixes: #101
Introduce BUILD_STATIC_LIBS to control building static libraries. Fixes: #99
Use correct ${CMAKE_BINARY_DIR}/gen paths for dependencies on generated
stubs. This ensures that CMake correctly regenerates them only if
jsonrpcstub or the spec file changes.
|
Ok, changed the library patch to just introduce |
|
Thank you very much! 👍 |
cinemast
added a commit
that referenced
this pull request
Apr 3, 2015
Build system fixes for develop branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #100, rebased for
developbranch.