-
-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake refactor #90
cmake refactor #90
Conversation
do we need these two lines in .travis.yml? - g++ ../src/examples/simpleclient.cpp -ljsonrpccpp-client -ljsoncpp -ljsonrpccpp-common -lcurl -o sampleclient
- g++ ../src/examples/simpleserver.cpp -ljsonrpccpp-server -ljsoncpp -ljsonrpccpp-common -lmicrohttpd -o sampleserver |
Yes. It should check if linking against the library without cmake is possible, after the library has been installed. |
are these changes ok for you? |
Great! Yes, I'm done :) |
|
||
# TODO not sure why some .h were not included | ||
# if we don't want to include it, remove it using list REMOVE_ITEM | ||
file(GLOB jsonrpc_header_common common/*.h) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Files were not included beacuse they are not part of the public API. Which makes it more easy to change internal functionality. Please revert that change, or use remove for all the others.
changes :
update, i will fix travis build in a minute |
I fixed issues. Can you review pull request again? |
After a quick review, it looks good. I will try to build on other platforms. If everything is fine. I will merge it. Thanks again for your contribution 👍 |
Aside that, everything looks fine. Don't forget to add yourself to the AUTHORS.md ;) |
done! |
Great! I guess a lot of people will appreciate MSVC support. Thanks again. |
cmake refactor + msvc support
this pull request is enhancement of #87
if fixes the following
unit_testsuite
in msvcDebug
mode in msvcinclude_directories
are not included globally any moreusr/include
&&usr/local/include
, they should be searched by default${CMAKE_SOURCE_DIR}/win32-deps/
moved toCMAKE_PREFIX_PATH
, so new cmake search paths are backwards compatibleFindJsoncpp.cmake
don't generate any files. Instead it's using PATH_SUFFIXES to solve jsoncpp versions incompatibility.changes:
Architecture of the library itself remained unchanged, i didn't want to create any incomatibilities with previous version