Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsonrpcstub --version #92

Merged
merged 3 commits into from
Feb 20, 2015
Merged

jsonrpcstub --version #92

merged 3 commits into from
Feb 20, 2015

Conversation

debris
Copy link
Contributor

@debris debris commented Feb 16, 2015

printing jsonrpcstub version.

In our project (ethereum), we are using jsonrpcstub as a part cmake build process. It would be helpful to know, what version of jsonrpcstub is installed on user machine.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.15%) to 99.85% when pulling 030590e on debris:version into 5dce039 on cinemast:master.

@debris
Copy link
Contributor Author

debris commented Feb 16, 2015

I'm not sure, why travis is failing for last commit. Can you help me @cinemast ?

@cinemast
Copy link
Owner

It seems that valgrind catches some memory losses. It is pretty late at the moment. I will take a closer look at it tomorrow.

The --version is a good idea. Thanks.

@cinemast
Copy link
Owner

The above comments should fix the build and remove the valgrind errors.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 3db1150 on debris:version into 5dce039 on cinemast:master.

@debris
Copy link
Contributor Author

debris commented Feb 19, 2015

thanks! I fixed issues

@cinemast
Copy link
Owner

Great, thank you!

cinemast pushed a commit that referenced this pull request Feb 20, 2015
@cinemast cinemast merged commit 89e98b5 into cinemast:master Feb 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants