Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App blackout when message contains a wrong closing tag #429

Closed
N-R-K opened this issue Mar 24, 2022 · 5 comments
Closed

App blackout when message contains a wrong closing tag #429

N-R-K opened this issue Mar 24, 2022 · 5 comments
Labels
type: bug Something isn't working
Milestone

Comments

@N-R-K
Copy link

N-R-K commented Mar 24, 2022

Describe the bug

On a certain room scrolling up a bit makes cinny black out entirely.

Reproduction

Not sure which message exactly is causing this, but on the console I see the following:
Uncaught TypeError: t.href is undefined

Expected behavior

No response

Platform and versions

1. OS GNU/Linux
2. Browser: Firefox 91.4.0
3. Cinny version: dev.cinny.in
4. Homeserver: matrix.org

Additional context

No response

@N-R-K N-R-K added the type: bug Something isn't working label Mar 24, 2022
@kfiven
Copy link
Collaborator

kfiven commented Mar 24, 2022

@N-R-K which room (if it's public)?

@N-R-K
Copy link
Author

N-R-K commented Mar 24, 2022

@kfiven It's public, yes: #gentoo-chatter:matrix.org

@N-R-K
Copy link
Author

N-R-K commented Mar 24, 2022

On a certain room scrolling up a bit makes cinny black out entirely.

Hmm, my wording was bad here. It's not scolling up itself that causes it, but rather scrolling up to a certain msg. Not sure which one, since everything goes blank.

@kfiven
Copy link
Collaborator

kfiven commented Mar 25, 2022

This was the message causing this:

<a href=https://yewtu.be/watch?v=wl-LeTFM8zo>HOW IT FEELS TO CHEW FIVE GUM GUM GUM YOUR STIMULATION<a/>

Whoever sent it, wrote closing tag wrong <a/> which is causing blackout.

@kfiven kfiven changed the title Everything blacks out: Uncaught TypeError: t.href is undefined App blackout when message contains a wrong closing tag Mar 25, 2022
ajbura added a commit that referenced this issue Mar 25, 2022
Signed-off-by: Ajay Bura <ajbura@gmail.com>
@kfiven kfiven added this to the v2.0.0 milestone Mar 25, 2022
@N-R-K
Copy link
Author

N-R-K commented Mar 25, 2022

Ahh, I see. Thanks for looking into this and fixing the bug.

@ajbura ajbura closed this as completed May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants