Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added paste image support on Tauri #1238

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

tobias-kuendig
Copy link

@tobias-kuendig tobias-kuendig commented May 13, 2023

Description

This PR introduces support to paste images when Cinny is running in the context of Tauri (cinny-desktop).

The implementation calls a new Tauri command introduced in cinnyapp/cinny-desktop#167. If an image is found in the clipboard, it is attached to the message. If not, the same logic as before will be used to populate the field from the clipboard.

This PR depends on cinnyapp/cinny-desktop#167

Fixes cinnyapp/cinny-desktop#69

Tested on Ubuntu 22.04 LTS on Wayland.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@github-actions
Copy link

github-actions bot commented May 13, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@tobias-kuendig
Copy link
Author

tobias-kuendig commented May 13, 2023

I have read the CLA Document and I hereby sign the CLA

@K4LCIFER
Copy link

What is the current status of this PR?

@PoneyClairDeLune
Copy link

Will this PR ever be merged?

@tobias-kuendig
Copy link
Author

While it is a shame that the PR is still open, please refrain from adding empty comments.

The PR will get merged when the maintainers have time to review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image paste not working from clipboard
3 participants