Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification sounds #367

Merged
merged 3 commits into from
Mar 18, 2022
Merged

Notification sounds #367

merged 3 commits into from
Mar 18, 2022

Conversation

ginnyTheCat
Copy link
Collaborator

@ginnyTheCat ginnyTheCat commented Mar 9, 2022

Description

Adds support for sound notifications and a settings option to disable this behavior.

image

I'm however not sure whether I added the credit for the sound resource correctly to the about section.

Fixes #173

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Preview: https://623363d2153c704052789d3b--pr-cinny.netlify.app
⚠️ Exercise caution. Use test accounts. ⚠️

Copy link
Member

@ajbura ajbura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The notification sound should work independent from desktop notification permission.

  1. sound can play even if desktop notification permission is disabled.
  2. notification sound can be toggle regardless of desktop notification permission.
  3. making desktop notification silent if notification sound is off is good idea, so it can stay as it is.
  4. using custom sound for desktop notification is good idea, so it can stay as it is.

apart from this notificaiton.ogg can be moved to /public/sound

@ginnyTheCat
Copy link
Collaborator Author

I personally don't like when a website plays a notification sound without an actual notification. I never know where the sound comes from. FluffyChat does this and has it's really annoying with no way of disabling it.

@ajbura
Copy link
Member

ajbura commented Mar 11, 2022

Notification doesn't mean desktop notification always. Desktop notifications already play system sound but what's lacking is the in-app notification sounds. For eg, invites, messages from room that you have on high priority, calls.

Without in-app notification sounds people can easily miss these updates. From a personal experience I have missed DM invites many times and after hours checked the invite button, same happened for pings.

@ginnyTheCat ginnyTheCat requested a review from ajbura March 17, 2022 16:37
@ajbura ajbura merged commit dc6e153 into cinnyapp:dev Mar 18, 2022
@ginnyTheCat ginnyTheCat deleted the notifications-sound branch March 18, 2022 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add sound notifications
2 participants