Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recently used section to emoji board #373

Merged
merged 6 commits into from
Mar 17, 2022

Conversation

ginnyTheCat
Copy link
Collaborator

@ginnyTheCat ginnyTheCat commented Mar 10, 2022

Description

Adds a recently used section (like element web has) to the emoji board.
Currently the icon in the sidebar is a heart. Personally I would think a clock would make for a better fit. I'm not a good designer though so I would leave the icon choice to @ajbura.

image

Fixes #194

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Preview: https://62331f8e1ac2861711b137df--pr-cinny.netlify.app
⚠️ Exercise caution. Use test accounts. ⚠️

src/app/organisms/emoji-board/recent.js Outdated Show resolved Hide resolved
src/app/organisms/emoji-board/recent.js Show resolved Hide resolved
src/app/organisms/emoji-board/recent.js Outdated Show resolved Hide resolved
src/app/organisms/emoji-board/EmojiBoard.jsx Outdated Show resolved Hide resolved
src/app/organisms/room/RoomViewCmdBar.jsx Show resolved Hide resolved
@ajbura
Copy link
Member

ajbura commented Mar 11, 2022

Ok I'll make a 🕓 icon

@ghost
Copy link

ghost commented Mar 12, 2022

Adding a separator (<hr />) between hearth and smiley icon would be better. Otherwise someone may think hearth icon is a different emoji section or something.

@ajbura
Copy link
Member

ajbura commented Mar 12, 2022

Heart icon going to be replaced by recent-clock icon

@kfiven kfiven merged commit b698982 into cinnyapp:dev Mar 17, 2022
@ginnyTheCat ginnyTheCat deleted the emoji-board-recent2 branch March 17, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Usability: Store recently used emojis
3 participants