Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort search results by activity #399

Merged
merged 2 commits into from
Mar 19, 2022
Merged

Sort search results by activity #399

merged 2 commits into from
Mar 19, 2022

Conversation

ajbura
Copy link
Member

@ajbura ajbura commented Mar 18, 2022

Signed-off-by: Ajay Bura ajbura@gmail.com

Description

This PR will sort CTRL + K search results by activity making active room easy to switch.
It also fix the bug when clicking cross button in search input won't discard the search results.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings

Preview: https://623465a6a28441116cf8ef5a--pr-cinny.netlify.app
⚠️ Exercise caution. Use test accounts. ⚠️

Signed-off-by: Ajay Bura <ajbura@gmail.com>
Signed-off-by: Ajay Bura <ajbura@gmail.com>
@ajbura ajbura marked this pull request as ready for review March 19, 2022 12:50
@ajbura ajbura merged commit ae71a99 into dev Mar 19, 2022
@ajbura ajbura added this to the v2.0.0 milestone Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants