Add mark as read button to space options #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BirdInFire
approved these changes
Jul 9, 2022
ajbura
reviewed
Jul 10, 2022
This allows users to mark all rooms in a space as read, matching similar features found in other popular chat applications. We opted to place the mark as read button at the top of the list instead of next to the add user button like in room options since we felt this will be the most-used button in the list. Fixes cinnyapp#645. Co-authored-by: Maple <mapletree.dv@gmail.com>
NovaAndrom3da
pushed a commit
to NovaAndrom3da/neocinny
that referenced
this pull request
Nov 23, 2023
This allows users to mark all rooms in a space as read, matching similar features found in other popular chat applications. We opted to place the mark as read button at the top of the list instead of next to the add user button like in room options since we felt this will be the most-used button in the list. Fixes cinnyapp#645. Co-authored-by: Maple <mapletree.dv@gmail.com> Co-authored-by: Maple <mapletree.dv@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows users to mark all rooms in a space as read, matching similar features found in other popular chat applications.
We opted to place the mark as read button at the top of the list instead of next to the add user button like in room options since we felt this will be the most-used button in the list.
Fixes #645
Co-authored-by: Maple mapletree.dv@gmail.com
Type of change
Checklist:
Preview: https://62ddf2b279f6ba4c52f34f83--pr-cinny.netlify.app
⚠️ Exercise caution. Use test accounts. ⚠️