Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perform ESC check before "ignore keybinds while focusing on inputs" check #669

Merged
merged 1 commit into from
Jul 18, 2022
Merged

Perform ESC check before "ignore keybinds while focusing on inputs" check #669

merged 1 commit into from
Jul 18, 2022

Conversation

deanveloper
Copy link
Contributor

@deanveloper deanveloper commented Jul 10, 2022 •
edited by github-actions bot

Description

Bug fix - allows you to press ESC to mark the current room as read while you are focused on the message text box

Fixes #668

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Preview: https://62ca6efe368e15032be224c5--pr-cinny.netlify.app
⚠️ Exercise caution. Use test accounts. ⚠️

@deanveloper
move input check after ESC check
f64ee96 
fixes #cinnyapp/cinny/668
@deanveloper deanveloper changed the title move input check after ESC check Perform ESC check before "ignore keybinds while focusing on inputs" check Jul 10, 2022
@ajbura ajbura merged commit 1211ca2 into cinnyapp:dev Jul 18, 2022
NovaAndrom3da pushed a commit to NovaAndrom3da/neocinny that referenced this pull request Nov 23, 2023
@deanveloper @NovaAndrom3da
Support mark as read by ESC while in room input (cinnyapp#669)
e60d5bd 
fixes #cinnyapp/cinny/668
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajbura ajbura ajbura approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cannot press ESC to mark current room as read while in text box
2 participants
@deanveloper @ajbura