Update Allowed Blob Mimetypes #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doesn't look like it plays |
Thumbscrew
force-pushed
the
support-additional-mime-types
branch
from
7d83193
to
72b5864
Compare
I tested in Firefox originally and it worked as is, but it looks like it didn't work in Chromium-based browsers. I've added additional commits to fix this but does feel like a bit of a hack... |
ajbura
approved these changes
Jul 18, 2022
|
Partially fixes #369 |
NovaAndrom3da
pushed a commit
to NovaAndrom3da/neocinny
that referenced
this pull request
Nov 23, 2023
* update allowed mimetypes * fix .mov files failing to play in Chromium * add check for before passing to FileReader * add missing semi-colon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds additional MIME-types to bring Cinny in line with matrix-react-sdk, but ultimately I just wanted to be able to play .mov (
video/quicktime) files in Cinny.Type of change
Checklist:
Preview: https://62d4c2613aae825088e7e0f5--pr-cinny.netlify.app
⚠️ Exercise caution. Use test accounts. ⚠️