Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show bridges active in room in settings #713

Closed
wants to merge 1 commit into from

Conversation

ginnyTheCat
Copy link
Collaborator

@ginnyTheCat ginnyTheCat commented Aug 3, 2022

Description

Shows the in room active bridges in the room settings in a new "Integrations" tab.
Clicking on the entry opens the platforms chat in a new tab (the Gitter bridge does this for example) or the services website (for example WhatsApp, Telegram)
Based on MSC2346

image
image

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Preview: https://713--pr-cinny.netlify.app
⚠️ Exercise caution. Use test accounts. ⚠️

Copy link
Member

@ajbura ajbura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a nice addition but having a dedicated tab for it doesn't sounds like a good idea. Most of the rooms doesn't have integration and it wont serve any purpose.

Maybe we can have a About tab at the end which can show info like, roomId, who & when room is created, and integrations?

@ginnyTheCat
Copy link
Collaborator Author

ginnyTheCat commented Aug 14, 2022

I thought that the integrations tab could later be extended with adding bridges and showing/adding bots.
I am open to the about tab idea as well though.

@kfiven
Copy link
Collaborator

kfiven commented May 22, 2024

Closing as stale.

@kfiven kfiven closed this May 22, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants