Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show full timestamp on hover #714

Merged
merged 3 commits into from
Aug 6, 2022
Merged

Show full timestamp on hover #714

merged 3 commits into from
Aug 6, 2022

Conversation

ginnyTheCat
Copy link
Collaborator

@ginnyTheCat ginnyTheCat commented Aug 4, 2022

Description

Shows the full date when hovering over a time of a message or event. It also changes it to not be date anymore for past days as the date can now be found out by hovering over the time.

image

Fixes #684

Type of change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Preview: https://62ed22314d1e7c6b09c6ffc4--pr-cinny.netlify.app
⚠️ Exercise caution. Use test accounts. ⚠️

@kfiven
Copy link
Collaborator

kfiven commented Aug 5, 2022

The format we planned when this was added was:

  • HH:MM AM/PM for the current day.
  • Yesterday HH:MM AM/PM for the past one day. (wasn't added)
  • DD/MM/YYYY for the rest of the timeline.
    And upon hovering over all of these we can see the full timestamp.

Since the date separator scroll with timeline, the HH:MM in all cases gets really confusing and was the reason for date for older messages.

@ginnyTheCat
Copy link
Collaborator Author

Should I add the yesterday case in as well?

@kfiven
Copy link
Collaborator

kfiven commented Aug 5, 2022

That'll be good addition.

@ajbura ajbura self-requested a review August 5, 2022 13:35
Copy link
Member

@ajbura ajbura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Message component is also used in RoomSearch.jsx so we need to change the time prop to timestamp there also.

Otherwise looks good

@ajbura ajbura merged commit 21726b6 into cinnyapp:dev Aug 6, 2022
@ginnyTheCat ginnyTheCat deleted the timestamp branch August 6, 2022 07:34
NovaAndrom3da pushed a commit to NovaAndrom3da/neocinny that referenced this pull request Nov 23, 2023
* Show full timestamp on hover

* Not always display time

* Always show full timestamp in search
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

View specific timestamps of older messages
3 participants