Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a button in the about screen to clear and reload the cache #793

Merged
merged 1 commit into from
Sep 17, 2022

Conversation

morguldir
Copy link
Contributor

@morguldir morguldir commented Aug 29, 2022

Description

The recent security issue in matrix-js-sdk can now be worked around by clearing the cache in element-web, this implements similar functionality in cinny, to avoid this bug without needing to log out. Also it's generally a useful thing when synapse acts up.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Placement was just to show the proof of concept, feel free to edit it.

cherry-picked from v2.12 if you want it https://github.com/morguldir/cinny/pull/new/clear-cache-and-reload-2.1.3

Preview: https://793--pr-cinny.netlify.app
⚠️ Exercise caution. Use test accounts. ⚠️

Copy link
Member

@ajbura ajbura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great. Thanks for adding it.

@ajbura ajbura merged commit 4848bef into cinnyapp:dev Sep 17, 2022
NovaAndrom3da pushed a commit to NovaAndrom3da/neocinny that referenced this pull request Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants