Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete notifications after messages have been read or deleted #830

Merged
merged 3 commits into from
Sep 11, 2022
Merged

Delete notifications after messages have been read or deleted #830

merged 3 commits into from
Sep 11, 2022

Conversation

ginnyTheCat
Copy link
Collaborator

@ginnyTheCat ginnyTheCat commented Sep 6, 2022 •
edited by github-actions bot
Loading

Description

Delete notifications after messages have been read or deleted.

Type of change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Preview: https://830--pr-cinny.netlify.app
⚠️ Exercise caution. Use test accounts. ⚠️

@ginnyTheCat ginnyTheCat marked this pull request as ready for review September 6, 2022 22:12
@ginnyTheCat ginnyTheCat force-pushed the notifications-delete branch 2 times, most recently from cc19e9d to 9f55eb7 Compare September 11, 2022 03:17
@ajbura ajbura merged commit b0174f3 into cinnyapp:dev Sep 11, 2022
@ginnyTheCat ginnyTheCat deleted the notifications-delete branch September 11, 2022 13:26
NovaAndrom3da pushed a commit to NovaAndrom3da/neocinny that referenced this pull request Nov 23, 2023
@ginnyTheCat @NovaAndrom3da
Delete notifications after messages have been read or deleted (cinnya…
d8006f2 
…pp#830)

* Delete read notifications

* Delete notifications for deleted messages

* Correctly remove notification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajbura ajbura ajbura approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ginnyTheCat @ajbura