Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(*): fix invalid service #142

Merged
merged 1 commit into from
May 14, 2019
Merged

fix(*): fix invalid service #142

merged 1 commit into from
May 14, 2019

Conversation

cipchk
Copy link
Owner

@cipchk cipchk commented May 14, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented May 14, 2019

Codecov Report

Merging #142 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #142      +/-   ##
==========================================
+ Coverage   85.46%   85.51%   +0.04%     
==========================================
  Files         113      113              
  Lines        1954     1960       +6     
  Branches      278      282       +4     
==========================================
+ Hits         1670     1676       +6     
  Misses        153      153              
  Partials      131      131
Impacted Files Coverage Δ
components/dialog/dialog.module.ts 100% <ø> (ø) ⬆️
components/actionsheet/actionsheet.module.ts 100% <ø> (ø) ⬆️
components/toast/toast.service.ts 69.56% <100%> (+2.89%) ⬆️
components/dialog/dialog.service.ts 100% <100%> (ø) ⬆️
components/actionsheet/actionsheet.service.ts 93.33% <100%> (+1.02%) ⬆️
components/toptips/toptips.service.ts 53.84% <100%> (+3.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9ddc6d...d12cee7. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented May 14, 2019

Codecov Report

Merging #142 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #142      +/-   ##
==========================================
+ Coverage   85.46%   85.51%   +0.04%     
==========================================
  Files         113      113              
  Lines        1954     1960       +6     
  Branches      278      282       +4     
==========================================
+ Hits         1670     1676       +6     
  Misses        153      153              
  Partials      131      131
Impacted Files Coverage Δ
components/dialog/dialog.module.ts 100% <ø> (ø) ⬆️
components/actionsheet/actionsheet.module.ts 100% <ø> (ø) ⬆️
components/toast/toast.service.ts 69.56% <100%> (+2.89%) ⬆️
components/dialog/dialog.service.ts 100% <100%> (ø) ⬆️
components/actionsheet/actionsheet.service.ts 93.33% <100%> (+1.02%) ⬆️
components/toptips/toptips.service.ts 53.84% <100%> (+3.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9ddc6d...d12cee7. Read the comment docs.

@cipchk cipchk merged commit a95da21 into master May 14, 2019
@cipchk cipchk deleted the issues-141 branch May 29, 2019 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7.0.0升级7.1.0 rc 1后使用ToptipsService报错
1 participant