Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: support ng7 #131

Merged
merged 12 commits into from
Dec 4, 2018
Merged

refactor: support ng7 #131

merged 12 commits into from
Dec 4, 2018

Conversation

cipchk
Copy link
Owner

@cipchk cipchk commented Dec 4, 2018

Related

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Dec 4, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@47aa15c). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #131   +/-   ##
=========================================
  Coverage          ?   86.19%           
=========================================
  Files             ?      102           
  Lines             ?     1912           
  Branches          ?      266           
=========================================
  Hits              ?     1648           
  Misses            ?      138           
  Partials          ?      126
Impacted Files Coverage Δ
components/polyfills.ts 100% <100%> (ø)
components/toast/toast.service.ts 66.66% <100%> (ø)
components/sidebar/sidebar-container.component.ts 76.74% <100%> (ø)
components/sidebar/sidebar.component.ts 89.52% <100%> (ø)
components/actionsheet/actionsheet.service.ts 92.85% <100%> (ø)
components/dialog/dialog.service.ts 100% <100%> (ø)
components/toptips/toptips.service.ts 50% <100%> (ø)
components/utils/base.service.ts 84% <100%> (ø)
components/sidebar/public-api.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47aa15c...b2e3154. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 4, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@47aa15c). Click here to learn what that means.
The diff coverage is 95.31%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #131   +/-   ##
========================================
  Coverage          ?   86.1%           
========================================
  Files             ?     102           
  Lines             ?    1914           
  Branches          ?     263           
========================================
  Hits              ?    1648           
  Misses            ?     140           
  Partials          ?     126
Impacted Files Coverage Δ
components/button/button.component.ts 100% <ø> (ø)
components/progress/progress.component.ts 90.9% <ø> (ø)
components/mask/mask.component.ts 95.45% <ø> (ø)
components/toast/toast.component.ts 96.15% <ø> (ø)
components/toptips/toptips.component.ts 100% <ø> (ø)
components/accordion/accordion-panel.component.ts 100% <ø> (ø)
components/tab/tabbar.component.ts 100% <100%> (ø)
components/polyfills.ts 100% <100%> (ø)
components/tab/bar.component.ts 78.04% <100%> (ø)
components/dialog/dialog.component.ts 86.86% <100%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47aa15c...986fad5. Read the comment docs.

@cipchk cipchk merged commit b992ad7 into master Dec 4, 2018
@cipchk cipchk deleted the dev-ng7 branch May 11, 2019 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant