Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tabbar): add activeIcon property #139

Merged
merged 1 commit into from
May 11, 2019
Merged

feat(tabbar): add activeIcon property #139

merged 1 commit into from
May 11, 2019

Conversation

cipchk
Copy link
Owner

@cipchk cipchk commented May 11, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented May 11, 2019

Codecov Report

Merging #139 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #139      +/-   ##
==========================================
+ Coverage    86.1%   86.13%   +0.02%     
==========================================
  Files         102      102              
  Lines        1914     1918       +4     
  Branches      263      264       +1     
==========================================
+ Hits         1648     1652       +4     
  Misses        140      140              
  Partials      126      126
Impacted Files Coverage Δ
components/tab/tabbar.component.ts 100% <ø> (ø) ⬆️
components/tab/tab.directive.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba9ccd7...818b9c3. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented May 11, 2019

Codecov Report

Merging #139 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #139      +/-   ##
==========================================
+ Coverage    86.1%   86.13%   +0.02%     
==========================================
  Files         102      102              
  Lines        1914     1918       +4     
  Branches      263      264       +1     
==========================================
+ Hits         1648     1652       +4     
  Misses        140      140              
  Partials      126      126
Impacted Files Coverage Δ
components/tab/tabbar.component.ts 100% <ø> (ø) ⬆️
components/tab/tab.directive.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba9ccd7...818b9c3. Read the comment docs.

@cipchk cipchk merged commit a1c2d05 into master May 11, 2019
@cipchk cipchk deleted the issues-135 branch May 11, 2019 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

weui-tab组件是否可提供两个property:选中时候显示的图标和未选中时候显示的图标
1 participant