Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add initial dockerfile and make commands #17

Merged
merged 6 commits into from
Jan 19, 2020
Merged

feat: add initial dockerfile and make commands #17

merged 6 commits into from
Jan 19, 2020

Conversation

nickshine
Copy link
Collaborator

No description provided.

@nickshine nickshine marked this pull request as ready for review January 19, 2020 04:35
circa10a
circa10a approved these changes Jan 19, 2020
View reviewed changes
Makefile Show resolved Hide resolved
@circa10a
Copy link
Owner

LGTM

Except this:

GOOS=windows GOARCH=amd64 go build $(BUILD_FLAGS) -o bin/windows/amd64/$(BINARY).exe

But what ya gonna do?

@circa10a circa10a merged commit 2b31919 into master Jan 19, 2020
@circa10a circa10a deleted the dockerize branch January 19, 2020 05:35
@nickshine nickshine mentioned this pull request Jan 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@circa10a circa10a circa10a approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nickshine @circa10a