New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile time only #28
Conversation
Codecov Report
@@ Coverage Diff @@
## master #28 +/- ##
==========================================
- Coverage 46.28% 44.04% -2.24%
==========================================
Files 12 11 -1
Lines 175 168 -7
Branches 4 3 -1
==========================================
- Hits 81 74 -7
Misses 94 94
Continue to review full report at Codecov.
|
This lib is now usable only at compile time.
f65f2e2
to
8200545
Compare
Thanks, @backuitist! |
I can go ahead and publish a new milestone tomorrow if that'd be useful, @backuitist? |
Eh, somewhat conflicts with our usage here (summoning circe-derivation codecs with implicit macro) https://github.com/pshirshov/izumi-r2/blob/develop/idealingua/idealingua-runtime-rpc-circe/src/main/scala/com/github/pshirshov/izumi/idealingua/runtime/circe/IRTWithCirce.scala#L8 |
@travisbrown yes, a release would be great! Thanks! @Kaishh I don't see how this change impacts your code? |
@backuitist It doesn't, but merging similar code upstream would mean creating |
@Kaishh We could have a new module named circe-derivation-extras (or something better), with the contract being that everything in circe-derivation can be used as a compile-time only dependency, while circe-derivation-extras would provide a runtime API with things like a |
@Kaishh I don't understand what you mean by "merging similar code upstream"? What is upstream? |
We have this situation where different team with different taste (one like circe-generic, another like circe-derivation) need to share circe codecs.
Having circe-derivation compile-time only makes it possible to define those codecs using circe-derivation without commiting (pulling one transitively) to either generic or derivation.