Migrated to munit instead of scalatest #339
Conversation
|
@Guisanpea Looks like this needs to have scalaFmtAll run over it :) |
Guisanpea
force-pushed
the
migrate-munit
branch
from
32dbde0
to
4cfb4b0
Compare
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #339 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 25 25
=========================================
Hits 25 25 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Hi @zmccoy check if now everything is all right :) |
| val result = serializeFoos(AsyncParser.UnwrapArray, fooStream(fooStdStream, fooVector)) | ||
| .through(stringArrayParser) | ||
| .through(chunkDecoder[IO, Foo2]) | ||
| .compile | ||
| .toVector | ||
| .attempt | ||
| result.map(r => assert(r.isLeft && r.left.get.isInstanceOf[DecodingFailure])) | ||
| } else { | ||
| IO.pure(()) |
There was a problem hiding this comment.
Instead of returning an IO.pure(()) it would be better to return a PropF.undecided and let scalacheck know that the generated values are being thrown away.
|
Hi @Guisanpea 👋 I'm a maintainer here now and happy to see this PR :) are you still able to work on it? |
No description provided.