Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update circe-jawn, circe-testing to 0.10.1 #9

Merged
merged 1 commit into from
Jan 2, 2019

Conversation

scala-steward
Copy link
Contributor

Updates

  • io.circe:circe-jawn
  • io.circe:circe-testing

from 0.10.0 to 0.10.1.

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention @scala-steward in the comments below.

Have a nice day!

@fthomas
Copy link

fthomas commented Nov 5, 2018

This does not look right. I'll try to fix it.

@codecov-io
Copy link

codecov-io commented Nov 5, 2018

Codecov Report

Merging #9 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #9   +/-   ##
=======================================
  Coverage   86.95%   86.95%           
=======================================
  Files           2        2           
  Lines          23       23           
  Branches        1        1           
=======================================
  Hits           20       20           
  Misses          3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4163ead...fa043bd. Read the comment docs.

@travisbrown
Copy link
Member

Thanks, @fthomas!

@scala-steward scala-steward force-pushed the update/circe-jawn-0.10.1 branch 2 times, most recently from b1a5fa1 to 6368616 Compare November 6, 2018 09:25
@vkostyukov
Copy link
Contributor

Is @scala-steward waiting on this PR to be merged before opening a new one that upgrades to Circe 0.11?

/cc @fthomas

@fthomas
Copy link

fthomas commented Dec 20, 2018

@vkostyukov Yes, that's right. It won't create a PR for a newer minor version if the project is not on the latest patch version. Likewise, it won't create a PR for a newer major version if the project is not on the latest minor version.

@fthomas
Copy link

fthomas commented Dec 24, 2018

This PR is now ready to be merged. I've changed scala-steward such that it won't change lines that contain "previous" before the artifact name.

@vkostyukov
Copy link
Contributor

@travisbrown Is there anything else left here? I've been keeping my eye on circe-iteratee release against Circe 0.11 and I believe when this is merged, scala-steward will perform the upgrade.

@travisbrown travisbrown merged commit 663cb38 into circe:master Jan 2, 2019
@travisbrown
Copy link
Member

Merged, thanks! I've got a lot of stuff to publish but probably won't get to it until the morning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants