Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend from Yaml Parser from Core Parser #338

Merged
merged 2 commits into from Nov 12, 2022

Conversation

zarthross
Copy link
Member

@zarthross zarthross commented Nov 4, 2022

Extending from io.circe.Parser adds some convenience methods to the io.circe.yaml.Parser out of the box, such as decodeAccumulating.

The io.circe.yaml.Parser class already matches the io.circe.Parser interface.

Also added decode and friends to the io.circe.yaml.parser package manually as well (using the io.circe.Parser trait had some compilation issues)

supersedes #284

@zarthross zarthross mentioned this pull request Nov 4, 2022
@zarthross zarthross requested a review from zmccoy November 4, 2022 21:58
@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2022

Codecov Report

Base: 91.66% // Head: 87.30% // Decreases project coverage by -4.36% ⚠️

Coverage data is based on head (e565d6d) compared to base (9822247).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #338      +/-   ##
==========================================
- Coverage   91.66%   87.30%   -4.37%     
==========================================
  Files           5        5              
  Lines         120      126       +6     
  Branches        7        6       -1     
==========================================
  Hits          110      110              
- Misses         10       16       +6     
Impacted Files Coverage Δ
src/main/scala/io/circe/yaml/Parser.scala 89.09% <0.00%> (-3.37%) ⬇️
src/main/scala/io/circe/yaml/parser/package.scala 37.50% <0.00%> (-12.50%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

TimoMeijer and others added 2 commits November 4, 2022 17:52
Extending from Parser adds some convenience methods to the Parser out of the box, such as `decodeAccumulating`.
The parser package object already matches the Parser interface.
@zarthross zarthross merged commit 9df6d5c into master Nov 12, 2022
@zarthross zarthross deleted the parser-decode-accumulating branch November 12, 2022 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants