Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bincompat problem with derivation in 0.14.4 on Scala 3 #2089

Closed
ybasket opened this issue Feb 9, 2023 · 2 comments · Fixed by #2090
Closed

Bincompat problem with derivation in 0.14.4 on Scala 3 #2089

ybasket opened this issue Feb 9, 2023 · 2 comments · Fixed by #2090

Comments

@ybasket
Copy link
Contributor

ybasket commented Feb 9, 2023

Hey,
first of all: Thank you for the library and the huge step forward #1800 brought. I found an issue with bincompat though:
If code using generic derivation on Scala 3 was compiled against an earlier 0.14 version of circe (in my case sttp-apispec), using it together with the new 0.14.4 may throw a NoSuchMethodError:

java.lang.NoSuchMethodError: 'scala.collection.Iterable io.circe.DerivedEncoder.encodedIterable$(io.circe.DerivedEncoder, scala.Product)'

The reason for that is that encodedIterable was not inline and got removed in #1800 (DerivedEncoder was kept package-private, but not the methods). Similar goes for DerivedDecoder, it has also a bunch of methods that are now removed.

Looking forward, one could (probably) either bring those back for bincompat and remove them in 0.15 or accept the breakage and ideally add a warning to the release notes.

ybasket added a commit to ybasket/circe that referenced this issue Feb 9, 2023
Implementation is just what has been there before circe#1800 (0.14.3).

Closes circe#2089
@ahjohannessen
Copy link

I got the same issue 👍 for the fix

@zarthross
Copy link
Member

Thanks for letting us know and for submitting the PR, we are looking into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants