New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Encoder.at #1537
Add Encoder.at #1537
Conversation
Thanks, looks good to me, but do you mind adding a test here? |
Added. Not sure if |
Class Codec no longer compiles because it inherits final member How do you want to solve this problem? Rename Encoder.at to something else? Suggestions:
|
Oh, right. Another alternative would be to add an |
👍 on the dummy implicit. |
@travisbrown have you reached a decision on whether to use a different name or a dummy implicit? Meanwhile I changed my opinion. I think using a different, carefully chosen name is simpler and conveys the programmers objective better. |
@travisbrown implemented the DummyImplicit |
The approach of DummyImplicit fails if we want to implement an |
Closes #1536