Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic derivation overhaul (with configurability) #164

Closed
wants to merge 8 commits into from

Conversation

travisbrown
Copy link
Member

Supersedes #163 and #79. Also fixes #69, although I'm not entirely sure why. Still needs tests before it gets merged.

@travisbrown
Copy link
Member Author

The build is failing because of an interaction between macro-compat and sbt-unidoc on 2.10 that I'll investigate later.

@codecov-io
Copy link

Current coverage is 77.24%

Merging #164 into master will decrease coverage by -0.26% as of 1d93c8f

Powered by Codecov. Updated on successful CI builds.

@travisbrown
Copy link
Member Author

For what it's worth, these changes may speed up compilation a bit (at least they do on my machine, from over a minute for tests/test:compile to under 50 seconds).

@travisbrown
Copy link
Member Author

Quick update: there's a problem here for e.g. the following nested case classes:

case class Foo(someField: Int)
case class Foos(foos: List[Foo])

In this case if you ask for a snake-case decoder for Foos the decoder it uses for each Foo won't be configured to use snake case.

I'm working on a fix that switches the inheritance relationship between Decoder and ConfiguredDecoder, and will update the PR soon.

@wennergr
Copy link

Any updates on this? Would love to see this PR move forward ;)

This was referenced Mar 20, 2016
@sveinnfannar
Copy link

Really looking forward to seeing this released :)

@travisbrown
Copy link
Member Author

@wennergr @sveinnfannar Unfortunately configurability won't be in 0.4.0, which will be out very soon (possibly today), but 0.4.0 does include an overhaul (see #247) in preparation for configurability that's bringing huge improvements in compile times and stability—see the 0.4.0-RC1 release notes, the link here, etc.

I'm hoping to have 0.5 out with configurability in the next couple of weeks, but no promises yet.

@sveinnfannar
Copy link

Thanks for the update @travisbrown!

@dvic
Copy link

dvic commented Sep 21, 2016

Any updates on this (in light of the 0.5.x releases)? Will this land in 0.6.x?

By the way, thanks a lot for this awesome library 👍 !

@travisbrown
Copy link
Member Author

Superseded (mostly) by #429.

@travisbrown travisbrown closed this Nov 2, 2016
julienrf pushed a commit to scalacenter/circe that referenced this pull request May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Derivation of big case class
5 participants