Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 0.12 Deprecations #1683

Merged
merged 1 commit into from Feb 27, 2021
Merged

Remove 0.12 Deprecations #1683

merged 1 commit into from Feb 27, 2021

Conversation

diesalbla
Copy link
Contributor

@diesalbla diesalbla commented Feb 27, 2021

WE remove all the items that have been marked as deprecated since versions 0.12.0 and 0.12.3, from September and October 2019 resp. This include the following elements:

  • The CursorOp move operations to move N items to the right or left, (in a Json array) or to move the the first item in the array.
  • The ACursor methods to do those same operations.
  • The pretty method for printing.
  • The AccumulatingDecoder class.

@diesalbla diesalbla changed the title ACursor: remove deprecated OPs Remove 0.12 Deprecations Feb 27, 2021
@travisbrown
Copy link
Member

Looks good to me! Will merge when green.

WE remove all the items that have been marked as deprecated since
versions 0.12.0 and 0.12.3, from September and October 2019 resp.
This include the following elements:

- The CursorOp move operations to move N items to the right or left,
  (in a Json array) or to move the the first item in the array.
- In the `ACursor` class we remove those methods.
- The `pretty` method for printing.
- The `AccumulatingDecoder` class.
@codecov-io
Copy link

codecov-io commented Feb 27, 2021

Codecov Report

Merging #1683 (00d8af4) into master (8d66dd7) will increase coverage by 0.78%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1683      +/-   ##
==========================================
+ Coverage   86.17%   86.95%   +0.78%     
==========================================
  Files          61       59       -2     
  Lines        2423     2392      -31     
  Branches      130      134       +4     
==========================================
- Hits         2088     2080       -8     
+ Misses        335      312      -23     
Impacted Files Coverage Δ
.../core/shared/src/main/scala/io/circe/ACursor.scala 71.42% <ø> (+6.91%) ⬆️
...core/shared/src/main/scala/io/circe/CursorOp.scala 55.55% <ø> (+2.43%) ⬆️
.../core/shared/src/main/scala/io/circe/Decoder.scala 86.13% <ø> (+0.49%) ⬆️
.../shared/src/main/scala/io/circe/FailedCursor.scala 72.72% <ø> (ø)
.../core/shared/src/main/scala/io/circe/HCursor.scala 90.62% <ø> (+18.12%) ⬆️
...les/core/shared/src/main/scala/io/circe/Json.scala 82.02% <ø> (+0.45%) ⬆️
.../core/shared/src/main/scala/io/circe/Printer.scala 95.21% <ø> (+0.87%) ⬆️
...d/src/main/scala/io/circe/cursor/ArrayCursor.scala 71.42% <ø> (-1.91%) ⬇️
.../src/main/scala/io/circe/cursor/ObjectCursor.scala 100.00% <ø> (ø)
...red/src/main/scala/io/circe/cursor/TopCursor.scala 100.00% <ø> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d66dd7...00d8af4. Read the comment docs.

@travisbrown
Copy link
Member

Looks good to me, thanks!

@travisbrown travisbrown merged commit ad68e71 into circe:master Feb 27, 2021
@diesalbla diesalbla deleted the drop_deprecated_methods branch February 27, 2021 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants