Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub URLs instead of local paths in SJSIR files #1703

Merged
merged 1 commit into from Mar 30, 2021

Conversation

fthomas
Copy link
Contributor

@fthomas fthomas commented Mar 30, 2021

This replaces local file paths in Scala.js SJSIR files with GitHub URLs.

It enables to see circe sources in the browser in Scala.js projects and gets rid of warnings like these in projects that use scalajs-bundler and webpack:

[warn] Module Warning (from ./node_modules/source-map-loader/index.js):
[warn] (Emitted value instead of an instance of Error) Cannot find source file
  '../../../../../../../../../../../../home/travis/code/projects/circe/modules/core/js/target/scala-2.13/src_managed/main/io/circe/TupleDecoders.scala'

Note that the same is done in Cats.

@codecov-io
Copy link

Codecov Report

Merging #1703 (839ca4e) into master (f144acd) will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1703      +/-   ##
==========================================
- Coverage   87.08%   86.99%   -0.09%     
==========================================
  Files          59       59              
  Lines        2392     2392              
  Branches      136      136              
==========================================
- Hits         2083     2081       -2     
- Misses        309      311       +2     
Impacted Files Coverage Δ
...re/shared/src/main/scala/io/circe/MapDecoder.scala 88.00% <0.00%> (-8.00%) ⬇️
...rc/main/scala/io/circe/numbers/BiggerDecimal.scala 88.30% <0.00%> (+1.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f144acd...839ca4e. Read the comment docs.

@travisbrown
Copy link
Member

Thanks for catching this!

@travisbrown travisbrown merged commit 0dc01f8 into circe:master Mar 30, 2021
@fthomas fthomas deleted the topic/scalajs-mapSourceURI branch March 30, 2021 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants