Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Shapeless 2.2.5 for 0.2.0 #87

Merged
merged 7 commits into from Nov 5, 2015
Merged

Use Shapeless 2.2.5 for 0.2.0 #87

merged 7 commits into from Nov 5, 2015

Conversation

travisbrown
Copy link
Member

After publishing 0.1.2 this morning I realized that after some recent changes to generic and the upgrade to export-hook 1.0.2, we no longer absolutely need new changes in Shapeless 2.3.0.

The changes here would allow us to publish circe 0.2.0 today against cats 0.2.0 and Shapeless 2.2.5. We'd then be able to spend some time with the bigger changes in #78, #79, and #85 and publish them in circe 0.3.0 when Shapeless 2.3.0 and cats 0.3.0 are available.

I hadn't fixed #55 and #57 because I was expecting them to be resolved when Shapeless's #453 is closed, but if we're publishing 0.2.0 against Shapeless 2.2.5 it makes sense to fix them now (so I did). If we go this route I'll open an issue about removing the ambiguous instances before 0.3.0

@travisbrown
Copy link
Member Author

For some reason the non-compilation tests that confirm that there are no Decoder[Object], etc. instances when using fully-automatic derivation are failing on 2.10 (using either ScalaTest's assertTypeError or Shapeless's illTyped), even though these instances aren't available either in the REPL or in a normally compiled program.

Because we're blocking these instances primarily to avoid confusing users, and since all other tests pass, I'm tempted to write this off as an issue with export-hook (or the non-compilation test mechanisms) and simply skip the tests on 2.10 (which is what I'm currently doing in this PR).

@travisbrown travisbrown force-pushed the topic/shapeless-2.2.5 branch 2 times, most recently from fab10e2 to 5433731 Compare November 4, 2015 20:05
@travisbrown
Copy link
Member Author

Okay, I'm going to fix #55 here but kick #57 down the road because I don't want to get bogged down in fighting with test-related issues that only show up on 2.10.

@codecov-io
Copy link

Current coverage is 69.56%

Merging #87 into master will increase coverage by +0.38% as of 5433731

Powered by Codecov. Updated on successful CI builds.

@ngbinh
Copy link
Contributor

ngbinh commented Nov 5, 2015

👍 would love to use circe now.

@yanana
Copy link

yanana commented Nov 5, 2015

👍

@travisbrown
Copy link
Member Author

This PR has become a kind of grab-bag of last little things for 0.2.0, but I think they're mostly uncontroversial, so once it's green I'll publish 0.2.0.

travisbrown added a commit that referenced this pull request Nov 5, 2015
@travisbrown travisbrown merged commit 44164e5 into master Nov 5, 2015
@travisbrown travisbrown deleted the topic/shapeless-2.2.5 branch November 12, 2015 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Odd incorrect encoding of heterogenous map
4 participants