Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close #979 by adding encoders and decoders for MonthDay, Year, and ZoneOffset #980

Merged
merged 1 commit into from Oct 11, 2018

Conversation

plokhotnyuk
Copy link
Contributor

@plokhotnyuk plokhotnyuk commented Oct 5, 2018

...and improve throughput of parsing and serialization of YearMonth values, by using build-in parser and formatter

@codecov-io
Copy link

codecov-io commented Oct 5, 2018

Codecov Report

Merging #980 into master will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #980      +/-   ##
==========================================
+ Coverage    85.3%   85.39%   +0.08%     
==========================================
  Files          75       75              
  Lines        2362     2362              
  Branches      159      159              
==========================================
+ Hits         2015     2017       +2     
+ Misses        347      345       -2
Impacted Files Coverage Δ
...rc/main/scala/io/circe/numbers/BiggerDecimal.scala 90% <0%> (-0.63%) ⬇️
.../core/shared/src/main/scala/io/circe/Decoder.scala 92.83% <0%> (-0.32%) ⬇️
...les/core/shared/src/main/scala/io/circe/Json.scala 79.48% <0%> (+0.64%) ⬆️
...re/shared/src/main/scala/io/circe/JsonNumber.scala 92.3% <0%> (+2.56%) ⬆️
...re/shared/src/main/scala/io/circe/KeyDecoder.scala 97.29% <0%> (+2.7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7765cc4...10df9db. Read the comment docs.

@travisbrown
Copy link
Member

Thanks @plokhotnyuk! Will get this merged shortly.

…nd ZoneOffset + improve throughput of parsing and serialization of YearMonth values
@plokhotnyuk
Copy link
Contributor Author

Also, I fixed formatting of comments and squashed commits.

As W/A it would better to add more tests for Java Time API codecs with custom formatters.

@travisbrown
Copy link
Member

As W/A it would better to add more tests for Java Time API codecs with custom formatters.

Agreed.

@travisbrown travisbrown merged commit 127057d into circe:master Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants