Infinite install bug

[yangchoo]

Meta:

CircleCI CLI Version:
v0.1.26786

Operating System:
cimg/base and all derived images.
I.e. Any Ubuntu 22.04.2 derived images. Most likely wider impact, unverified.

CircleCI CLI Diagnostic:
n/a

Current behavior:

Unable to install circlecli from install.sh script. Results in infinite install loop. Breaks any builds which rely on circleci cli installation following official install script instructions.

❯ docker run cimg/base:2023.05 curl -fLSs https://raw.githubusercontent.com/CircleCI-Public/circleci-cli/main/install.sh | bash
Starting installation.
Installing CircleCI CLI v0.1.26786
Installing to /usr/local/bin
Starting installation.
Installing CircleCI CLI v0.1.26786
Installing to /usr/local/bin
Starting installation.
Installing CircleCI CLI v0.1.26786
Installing to /usr/local/bin
Starting installation.
Installing CircleCI CLI v0.1.26786
^C

Expected behavior:

CircleCI should install correctly without infinite recursion.

When did this begin / Was this previously working?:

Since new version was released. v0.1.26646 was last observed to work.

Additional Information:

Likely a result of #352

See #352 (comment)

[dmartin-gresham]

I think the bug is in this line:

circleci-cli/install.sh

Line 73 in efe60d3

install circleci "$DESTDIR"

It's trying to call the linux install command, but that's been redefined on line 19.

[JulesFaucherre]

Thanks for reporting, this has been solved with the following pr