Merge pull request #303 from CoinbaseStablecoin/v2-oz-L01

Use token name instead of hard-coding "FiatToken" in EIP712 domain definition [L01]
circlefin · Jul 17, 2020 · 9de45f0 · 9de45f0
2 parents 5dcac53 + 916e2a2
commit 9de45f0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/contracts/v2/FiatTokenV2.sol b/contracts/v2/FiatTokenV2.sol
@@ -55,7 +55,7 @@ contract FiatTokenV2 is
             "FiatTokenV2: contract is already initialized"
         );
         name = newName;
-        DOMAIN_SEPARATOR = EIP712.makeDomainSeparator("FiatToken", "2");
+        DOMAIN_SEPARATOR = EIP712.makeDomainSeparator(newName, "2");
         _initializedV2 = true;
     }
 

diff --git a/test/v2/FiatTokenV2.test.ts b/test/v2/FiatTokenV2.test.ts
@@ -47,7 +47,7 @@ contract("FiatTokenV2", (accounts) => {
           web3.utils.keccak256(
             "EIP712Domain(string name,string version,uint256 chainId,address verifyingContract)"
           ),
-          web3.utils.keccak256("FiatToken"),
+          web3.utils.keccak256("USD Coin"),
           web3.utils.keccak256("2"),
           chainId,
           fiatToken.address,