Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing null checks #252

Closed
eztierney opened this issue Jan 11, 2019 · 0 comments
Closed

Missing null checks #252

eztierney opened this issue Jan 11, 2019 · 0 comments
Assignees
Labels
multi-issuer Issues related to the multi-issuer branch

Comments

@eztierney
Copy link
Contributor

In several places in the code, addresses are passed as parameters to functions. In many of these instances, the functions do not validate that the passed address is not the null address 0. In the Controller contract, this happens in functions configureController (which only checks _worker) and removeController.

In the MintController contract, on the other hand, it might be expected that the constructor sets the minterManager variable to 0, but the setMinterManager function does not prevent setting it to 0.

@eztierney eztierney added the multi-issuer Issues related to the multi-issuer branch label Jan 11, 2019
mirathewhite pushed a commit that referenced this issue Jan 16, 2019
* add null address check to removeController and configureController
* update unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
multi-issuer Issues related to the multi-issuer branch
Projects
None yet
Development

No branches or pull requests

3 participants