checkDiff validates Etherscan source code #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walkerq
reviewed
Aug 9, 2018
validate/contractDiff.js
Outdated
| } | ||
| } | ||
|
|
||
| console.log(); |
There was a problem hiding this comment.
There's a few empty console.log statements in this block that can be deleted
There was a problem hiding this comment.
replaced console.log() with extra "\n" in process.stdout.write(...) statements.
validate/contractDiff.js
Outdated
| console.log() | ||
| process.stdout.write(chalk.green("Successfully processed " + (total-fail) + " files.\n")); | ||
| process.stdout.write(chalk.green(goodFiles)); | ||
| process.stdout.write(chalk.red("\n\nFailed to process " + fail + " files.\n")); |
There was a problem hiding this comment.
Can we only print this if fail > 0?
validate/README.checkDiff.md
Outdated
| The `checkDiff` script compares source code uploaded to Etherscan to source | ||
| code on the local machine. | ||
|
|
||
| The souce code in Etherscan is a concatenation of several files. The script reads |
validate/README.checkDiff.md
Outdated
|
|
||
| 1. Comments / whitespace | ||
| 2. The local code has `import` statements not included in Etherscan because the files were | ||
| explictly concatenated into a master file. |
There was a problem hiding this comment.
typo: explictly -> explicitly
|
Created CENT-257 to create ABI validation script in USDC v2. |
walkerq
approved these changes
Aug 10, 2018
zhenghui-w
pushed a commit
to zhenghui-w/stablecoin-evm
that referenced
this pull request
Apr 8, 2024
…irclefin#192) ## Summary This pull request modifies `FiatTokenCeloV2_2` to allow greater flexibility in who the fee caller for `debitGasFees` and `creditGasFees` can be. Circle has decided to pursue an approach (pending Security, Rui Maximo) in which yet another contract in the call stack calls `debitGasFees` and `creditGasFees`. To that end, we cannot rely on our assumption of 0x0 being the fee caller anymore. ## Detail - Modified FTCV2.2 to account for a dynamic fee caller. This is stored in a Keccak256 storage slot to prevent modification to the USDC storage layout. - Ensured that only the token owner can call `updateFeeCaller`, similar to existing procedures for the blacklister, pauser, etc. - Modified contracts where appropriate and added tests. ## Testing See the tests. ## Documentation - [`FiatTokenFeeAdapter` rollout plan/timeline](https://docs.google.com/document/d/19qISUWAft_yCzg5lPrf41f2m3Bxgi7RQTIqeLZ6_Ghw/edit) - [Product document](https://docs.google.com/document/d/1YKVpFo9aPuBREX7eXcXinFLpskF5q9nUxvbBd0ifYl8) ## Sanitization - [x] Will this commit be publicized? Depending on whether we squash during open-sourcing, it may or may not be. @zhenghui-w is handling the open-sourcing effort. For PR author, have you: - [x] Checked that PR title does not contain internal references? (eg. internal code names, employee names) - [x] Checked that commit messages do not contain internal references? (eg. internal code names, employee names) - [x] Checked that all new code contain the Apache 2.0 copyright license header - [x] Checked that all new third party dependencies use permissive licenses For reviewers, ensure that: - The PR is squash merged - JIRA story IDs are removed from the squash merge commit title Refer to the [Open Source Standard](https://drive.google.com/file/d/1OV5E9ZOBmyZeN877vPP02C92Mjm-qt4Z/view) for more information about sanitization. ## Story STABLE-5628
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a script that compares the source code downloaded from Etherscan to files stored on the local machine. It reads the Etherscan code to learn which local files to use, then reads the local files and concatenates them into an "expected" source file. Then it shows a diff. Usage instructions are in validate/README.checkDiff.md.
Also included copies of files downloaded directly from Etherscan: FiatTokenProxy.etherscan and FiatTokenV1.etherscan. These are for testing purposes only. Actual validation should be performed by manually downloading the files from Etherscan (instructions in validate/README.checkDiff.md).