Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solidity style fixes to multi-issuer contracts #243

Merged
merged 7 commits into from
Jan 11, 2019
Merged

Solidity style fixes to multi-issuer contracts #243

merged 7 commits into from
Jan 11, 2019

Conversation

walkerq
Copy link
Contributor

@walkerq walkerq commented Jan 9, 2019

Wraps lines at 80 columns per Solidity style guide. Also uses double quotes in import statements.

eztierney
eztierney requested changes Jan 10, 2019
View reviewed changes
Copy link
Contributor

@eztierney eztierney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - can you change all the modifiers to be on their own line?

contracts/minting/Controller.sol Outdated Show resolved Hide resolved
@walkerq
Copy link
Contributor Author

walkerq commented Jan 11, 2019

Addressed your comment @eztierney. Also removed unnecessary ./from Ownable import, and moved visibility modifiers before other modifiers, according to the style guide.

@eztierney
Copy link
Contributor

Fixes
#255
#256
#266

@eztierney eztierney merged commit 4e0047d into multi-issuer Jan 11, 2019
This was referenced Jan 11, 2019
Closed
Closed
Closed
Closed
@walkerq walkerq mentioned this pull request Jan 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eztierney eztierney eztierney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@walkerq @eztierney