Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CENT642: Move MinterManagementInterface to its own file #251

Merged
merged 5 commits into from
Jan 14, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions contracts/minting/MintController.sol
Original file line number Diff line number Diff line change
Expand Up @@ -23,21 +23,9 @@
pragma solidity ^0.4.24;

import "./Controller.sol";
import "./MinterManagementInterface.sol";
import "openzeppelin-solidity/contracts/math/SafeMath.sol";

// Using an interface for managing minters so that MintController
// can be used for managing minters with different contracts.
interface MinterManagementInterface {
function isMinter(address account) external view returns (bool);
function minterAllowance(address minter) external view returns (uint256);
function configureMinter(
address minter,
uint256 minterAllowedAmount
)
external returns (bool);
function removeMinter(address minter) external returns (bool);
}

/**
* @title MintController
* @dev allows control of configure/remove minter by different addresses
Expand Down
31 changes: 31 additions & 0 deletions contracts/minting/MinterManagementInterface.sol
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
/**
* Copyright CENTRE SECZ 2019
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to deal
* in the Software without restriction, including without limitation the rights
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the Software is furnished to
* do so, subject to the following conditions:
*
* The above copyright notice and this permission notice shall be included in all
* copies or substantial portions of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
* CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
*/

pragma solidity ^0.4.24;

// Using an interface for managing minters so that MintController
// can be used for managing minters with different contracts.
interface MinterManagementInterface {
function isMinter(address account) external view returns (bool);
function minterAllowance(address minter) external view returns (uint256);
function configureMinter(address minter, uint256 minterAllowedAmount) external returns (bool);
function removeMinter(address minter) external returns (bool);
}
1 change: 0 additions & 1 deletion test/minting/MintP0_ArgumentTests.js
Original file line number Diff line number Diff line change
Expand Up @@ -212,4 +212,3 @@ async function run_MINT_tests(newToken, MintControllerArtifact, accounts) {
var testWrapper = require('./../TestWrapper');
testWrapper.execute('MINTp0_ArgumentTests MintController', run_tests_MintController);
testWrapper.execute('MINTp0_ArgumentTests MasterMinter', run_tests_MasterMinter);