Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Macro detection #118

Closed
wants to merge 81 commits into from
Closed

Add Macro detection #118

wants to merge 81 commits into from

Conversation

InvisibleSymbol
Copy link
Contributor

Basically looks at how many extremely short presses were done in a replay. If it's over a threshold, it's cheated.

@tybug
Copy link
Contributor

tybug commented Dec 7, 2019

Got sidetracked by mildly rewriting Detect to allow for statements like d.requires(Detect.REQUIRES_BEATMAP) or Detect.INVESTIGATION in d, which will reduce nasty multiple if statements. That should be a separate pr but I'm lazy and will push it here. Will review/complete that tomorrow

tybug and others added 25 commits January 3, 2020 16:39
@tybug
Merge branch 'macro_detect' of github.com:circleguard/circlecore into…
694ef45 
… macro_detect
@samuelhklumpers
add missing array cast and fix typo
5bc1a05
@tybug
fix typo and line length
0524225
@tybug
rearrange documentation
153365c
@tybug
note hill climbing in comments
5978e71
@tybug
add CleanMode to __init__
c278453
@tybug
remove duplicate import
d6d8a3b
@tybug
Merge branch 'release' into cleaning_tests
56792b1
@samuelhklumpers
add enum class for CleanOption
dc44a02
@tybug
tidy up code
acc5764
@tybug
use math.inf for hill climb starting value
0c07b67
@tybug
more hill climb documentation
5bd889e
@tybug
remove comment
fa06f70
@tybug
new CleanMode classes, reword docs and remove ALL
e1f063f
@tybug
remove CleanMode documentation
93f6bc3
@tybug
remove copy import
1b195fc
@tybug
reword comparer docs
f290a13
@tybug
add CMode imports
25716f6
@tybug
fix error with using CleanMode enum
2053322
@tybug
fix StealDetect default CleanMode
cbec267
@samuelhklumpers
Merge branch 'cleaning_tests' into macro_detect
5f829c6 
# Conflicts:
#	CHANGELOG
#	circleguard/__init__.py
#	circleguard/circleguard.py
#	circleguard/enums.py
@samuelhklumpers
implement numpy parse_key methods
d73059f
@samuelhklumpers
Merge remote-tracking branch 'origin/macro_detect' into macro_detect
a9997c7
@InvisibleSymbol
only use hits if they actually hit a hitcircle
b6a9852
@InvisibleSymbol
Merge branch 'macro_detect' of https://github.com/circleguard/circlecore
75662cc 
 into macro_detect
@InvisibleSymbol InvisibleSymbol mentioned this pull request Mar 8, 2020
Merged
@InvisibleSymbol InvisibleSymbol changed the base branch from release to master March 8, 2020 20:16
@tybug
Copy link
Contributor

tybug commented Mar 11, 2021

Going to close mostly per #119 (comment). The only thing new in this branch is seeing how many keypresses in a replay are under a certain number of ms. Something we should have, but that would need rewriting anyway given how much circlecore has changed.

@tybug tybug closed this Mar 11, 2021
@tybug tybug deleted the macro_detect branch March 11, 2021 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tybug tybug Awaiting requested review from tybug

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@InvisibleSymbol @tybug @samuelhklumpers